Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BED-5484 Removed extra step from NTLM [LDAP, LDAPS, ADCS] WindowsAbuse copy #1200

Merged
merged 1 commit into from
Mar 5, 2025
Merged

BED-5484 Removed extra step from NTLM [LDAP, LDAPS, ADCS] WindowsAbuse copy #1200

merged 1 commit into from
Mar 5, 2025

Conversation

mvlipka
Copy link
Contributor

@mvlipka mvlipka commented Mar 5, 2025 •
edited
Loading

Description

SMB steps were accidentally added to the LDAP, LDAPS, and ADCS WindowsAbuse copy
This simply removes the step

Motivation and Context

This PR addresses: BED-5484

How Has This Been Tested?

image image

Screenshots (optional):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

@mvlipka mvlipka added the bug Something isn't working label Mar 5, 2025
@mvlipka mvlipka marked this pull request as ready for review March 5, 2025 22:25
zinic
zinic approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@zinic zinic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull!

superlinkx
superlinkx approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@superlinkx superlinkx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Pull!

@mvlipka mvlipka merged commit 6ea3c21 into stage/v7.1.0 Mar 5, 2025
6 checks passed
@mvlipka mvlipka deleted the BED-5484/NTLM-Correct-WindowsAbuse-Steps branch March 5, 2025 22:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zinic zinic zinic approved these changes

@superlinkx superlinkx superlinkx approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mvlipka @zinic @superlinkx